Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Away: Fix broken user group notification feature #1145

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Away: Fix broken user group notification feature #1145

merged 5 commits into from
Dec 19, 2024

Conversation

blackcoder87
Copy link
Member

@blackcoder87 blackcoder87 commented Dec 18, 2024 •
edited
Loading

Description

  • Add getUserListByGroupIds() to user mapper and use that function in the away module.
  • Require ilchCore 2.2.7 for the away module.
  • Add unit tests for getUserListByGroupIds() and getUserListByGroupId().

Mit dem jetzt angegebenen Datentyp "int" für groupId tritt folgender Fehler auf:

Uncaught TypeError: Argument 1 passed to Modules\User\Mappers\User::getUserListByGroupId() must be of the type int, array given, called in application/modules/away/controllers/Index.php on line 93 and defined in application/modules/user/mappers/User.php:114
Stack trace:
#0 application/modules/away/controllers/Index.php(93): Modules\User\Mappers\User->getUserListByGroupId()
#1 application/libraries/Ilch/Page.php(243): Modules\Away\Controllers\Index->indexAction()
#2 application/libraries/Ilch/Page.php(137): Ilch\Page->loadController()
#3 index.php(68): Ilch\Page->loadPage()
#4 {main}
  thrown in application/modules/user/mappers/User.php on line 114

Vorher trat kein Fehler auf, aber es hat nicht wie gewünscht funktioniert. Die Benutzergruppen wurden "und"-Verknüpft. Der Benutzer hat die Benachrichtigung nur bekommen, wenn er in allen Benutzergruppen war.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Opera
  • Edge

@blackcoder87 blackcoder87 mentioned this pull request Dec 18, 2024
Merged
6 tasks
@blackcoder87 blackcoder87 merged commit 6e6efbc into master Dec 19, 2024
6 checks passed
@blackcoder87 blackcoder87 deleted the away-user-fix-notification-issues branch December 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhunderter hhunderter Awaiting requested review from hhunderter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blackcoder87